Skip to content

move loginWithWallet function to core and add tests #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2025
Merged

move loginWithWallet function to core and add tests #140

merged 1 commit into from
Jan 30, 2025

Conversation

nikgraf
Copy link
Collaborator

@nikgraf nikgraf commented Jan 30, 2025

No description provided.

@nikgraf nikgraf self-assigned this Jan 30, 2025
@nikgraf nikgraf changed the title move auth functions move loginWithWallet function to core and add tests Jan 30, 2025
pcarranzav
pcarranzav approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@pcarranzav pcarranzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikgraf nikgraf merged commit 2559ee2 into main Jan 30, 2025
4 checks passed
@nikgraf nikgraf deleted the ng/move-more-auth-functions branch January 30, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcarranzav pcarranzav pcarranzav approved these changes

@cmwhited cmwhited Awaiting requested review from cmwhited

Assignees

@nikgraf nikgraf

Labels

None yet

Projects

None yet

Milestone

Phase 3: Improvements & Cleanup

Development

Successfully merging this pull request may close these issues.

2 participants

@nikgraf @pcarranzav